Skip to content

Comments

Parameter dataclass refactoring#56

Draft
kaghi wants to merge 33 commits intomainfrom
parameter-dataclass-refactoring
Draft

Parameter dataclass refactoring#56
kaghi wants to merge 33 commits intomainfrom
parameter-dataclass-refactoring

Conversation

@kaghi
Copy link
Contributor

@kaghi kaghi commented Jan 28, 2026

redux of refactoring parameters into a single dataclass that can be passed through functions efficiently.

daharoni and others added 30 commits January 22, 2026 11:49
…orporating in DeconvBin.

Defined an initialize_solver function.
…ting self._solver.

Started refactoring _compute_err to optimize numerical computations and readability.
… inference steps in the Deconv class to their own file (thres_and_solv.py). Started by refactoring max_thres. Other functions I am working on are solv, _max_thres, and solve_thres, all of which are part of the deconv.py file.
…ere it doesn't initialize. I keep getting this:

 AttributeError: 'NoneType' object has no attribute 'shape'

indeca\core\deconv\solver.py:596: AttributeError
…plemented as it is currently not working. Raising issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants